On Mon, 17 Aug 2020 15:02:27 -0500 Adam Ford <aford173@xxxxxxxxx> wrote: > On Mon, Aug 17, 2020 at 2:59 PM Andreas Kemnade <andreas@xxxxxxxxxxxx> wrote: > > > > On Mon, 17 Aug 2020 08:39:31 -0500 > > Adam Ford <aford173@xxxxxxxxx> wrote: > > > > > The OMAP3530, OMAP3630, and DM3730 all show thresholds of 90C and 105C > > > depending on commercial or industrial temperature ratings. > > > > > > This patch expands the thermal information to include the limits of 90 > > > and 105C for alert and critical. It sets the coolings-cells for the > > > 34xx and 36xx CPU's which both point to omap3-cpu-thermal.dtsi. > > > > > > For boards who never use industrial temperatures, these can be > > > changed on their respective device trees with something like: > > > > > > &cpu_alert0 { > > > temperature = <85000>; /* millicelsius */ > > > }; > > > > > > &cpu_crit { > > > temperature = <90000>; /* millicelsius */ > > > }; > > > > > > OMAP3_THERMAL will need to be enabled. It is off by default. > > > > > hmm, I think the patch for idling core when OMAP3_THERMAL is enabled > > got stuck somewhere. It still seems not to work. Shouldn't that patch > > be applied first? > > I rebased the idle stuff, and now I get errors, so I haven't pushed it > yet. I put a note that OMAP3_THERMAL is off by default, but this > patch would at least get the framing in there. I know at least two of > us that use 1GHZ processors which are not supposed to run at that > speed above 90MHz, so the idea was to tolerate the higher current for > now, and when the idle stuff works, we'll enable the OMAP3_THERMAL by > default. > yes, makes sense, so with this patch we have the choice to either optimize for low speeds and currents (by disabling OMAP3_THERMAL and 1GHz) or high speeds (by enabling OMAP3_THERMAL and 1 Ghz). Regards, Andreas