> -----Original Message----- > From: Krzysztof Wilczyński <kw@xxxxxxxxx> > Sent: Sunday, August 2, 2020 10:26 PM > To: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > Cc: Jingoo Han <jingoohan1@xxxxxxxxx>; Kukjin Kim <kgene@xxxxxxxxxx>; > Krzysztof Kozlowski <krzk@xxxxxxxxxx>; Richard Zhu > <hongxing.zhu@xxxxxxx>; Lucas Stach <l.stach@xxxxxxxxxxxxxx>; Shawn > Guo <shawnguo@xxxxxxxxxx>; Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>; > Murali Karicheri <m-karicheri2@xxxxxx>; Yue Wang > <yue.wang@xxxxxxxxxxx>; Kevin Hilman <khilman@xxxxxxxxxxxx>; Thomas > Petazzoni <thomas.petazzoni@xxxxxxxxxxx>; Jesper Nilsson > <jesper.nilsson@xxxxxxxx>; Xiaowei Song <songxiaowei@xxxxxxxxxxxxx>; > Binghui Wang <wangbinghui@xxxxxxxxxxxxx>; Pratyush Anand > <pratyush.anand@xxxxxxxxx>; Hou Zhiqiang <Zhiqiang.Hou@xxxxxxx>; > Linus Walleij <linus.walleij@xxxxxxxxxx>; Toan Le > <toan@xxxxxxxxxxxxxxxxxxxxxx>; Tan, Ley Foon > <ley.foon.tan@xxxxxxxxx>; Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>; Heiko > Stuebner <heiko@xxxxxxxxx>; linux-amlogic@xxxxxxxxxxxxxxxxxxx; linux-arm- > kernel@xxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux- > omap@xxxxxxxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx; linux- > rockchip@xxxxxxxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx; linux- > tegra@xxxxxxxxxxxxxxx; rfi@xxxxxxxxxxxxxxxxxxxxxx > Subject: [PATCH 04/10] PCI: altera: Remove dev_err() when handing an error > from platform_get_irq() > > There is no need to call the dev_err() function directly to print a custom > message when handling an error from either the platform_get_irq() or > platform_get_irq_byname() functions as both are going to display an > appropriate error message in case of a failure. > > This change is as per suggestion from Coccinelle: > > drivers/pci/controller/pcie-altera.c:717:2-9: line 717 is redundant > because platform_get_irq() already prints an error > > Suggested-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > Signed-off-by: Krzysztof Wilczyński <kw@xxxxxxxxx> > --- Reviewed-by: Ley Foon Tan <ley.foon.tan@xxxxxxxxx>
