I still get following warnings from checkpatch.pl:
WARNING: suspect code indent for conditional statements (0, 2)
#45: FILE: drivers/dsp/bridge/pmgr/wcd.c:151:
+do { \
+ if (DSP_SUCCEEDED(status)) { \
WARNING: suspect code indent for conditional statements (2, 4)
#46: FILE: drivers/dsp/bridge/pmgr/wcd.c:152:
+ if (DSP_SUCCEEDED(status)) { \
+ if (unlikely((src) == NULL) || \
ERROR: code indent should use tabs where possible
#49: FILE: drivers/dsp/bridge/pmgr/wcd.c:155:
+ GT_1trace(WCD_debugMask, GT_7CLASS,^I\$
WARNING: suspect code indent for conditional statements (0, 2)
#57: FILE: drivers/dsp/bridge/pmgr/wcd.c:163:
+do { \
+ if (DSP_SUCCEEDED(status)) { \
WARNING: suspect code indent for conditional statements (2, 4)
#58: FILE: drivers/dsp/bridge/pmgr/wcd.c:164:
+ if (DSP_SUCCEEDED(status)) { \
+ if (unlikely((dest) == NULL) || \
ERROR: code indent should use tabs where possible
#61: FILE: drivers/dsp/bridge/pmgr/wcd.c:167:
+ GT_1trace(WCD_debugMask, GT_7CLASS,^I\$
ERROR: code indent should use tabs where possible
#62: FILE: drivers/dsp/bridge/pmgr/wcd.c:168:
+ "copy_to_user failed, dest=0x%x\n", dest);^I\$
ERROR: code indent should use tabs where possible
#63: FILE: drivers/dsp/bridge/pmgr/wcd.c:169:
+ (status) = DSP_EPOINTER ;^I^I\$
total: 4 errors, 4 warnings, 48 lines checked
I have used 2 spaces instead of a tab for indentation so that line
won't exceed 80 columns limit, and we still maintain good amount of
readability with this macro.
Cheers,
Ameya.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
