On Fri, 26 Jun 2020, Mark Brown wrote: > On Fri, Jun 26, 2020 at 07:57:35AM +0100, Lee Jones wrote: > > > Until now the aforementioned return value has been ignored. > > This is only aforementioned in the subject. > > > /* Store default strobe info */ > > ret = tps65217_reg_read(tps, regulators[i].bypass_reg, &val); > > + if (ret) > > + return ret; > > + > > We should really be logging an error there rather than just returning, > that way it's a bit more apparent to someone debugging things what went > wrong if there is actually a problem. Would you like me to fix that up subsequently? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
