Hi Sebastian, > Am 25.02.2020 um 00:20 schrieb Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>: > > This updates the existing omapdrm DSI code, so that it uses > common drm_mipi_dsi API and drm_panel. > > The patchset has been tested with Droid 4 using Linux console, X.org and > Weston. The patchset is based on Laurent Pinchartl's patch series [0] > and removes the last custom panel driver, so quite a few cleanups on the > omapdrm codebase were possible. > > [0] [PATCH v7 00/54] drm/omap: Replace custom display drivers with drm_bridge and drm_panel > https://lore.kernel.org/dri-devel/20200222150106.22919-1-laurent.pinchart@xxxxxxxxxxxxxxxx/ > git://linuxtv.org/pinchartl/media.git omapdrm/bridge/devel > > I pushed this patchset into the following branch: > > git://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-n900.git omapdrm/bridge/devel-with-dsi > > The previous version of this patchset has been sent quite some time ago. > This version has been rebased and required cleaning up most of the > hacks. I do not have a detailed changelog, but quite a few things > changed. I decided against doing anything special for the DT change > (adding DSI channel number), since only 3 devices are affected. It is > quite likely, that all developers of those devices update DT together > with kernel for those devices. My suggestion is to merge the first two > patches ASAP and backport to stable, since it does not affect old > kernels and the change is rather small. > > RFCv1: https://lore.kernel.org/dri-devel/20191117023946.VjCC3yE08DMx7JIKxNagPoT5et7WTnKGVV6MtOtB9Ro@z/ is there something new for this series? Is there a repo where it has been rebased to v5.8-rc1 (and tested)? Our Pyra MIPI/DSI omap5 panel setup is broken by upstream changes since v5.7-rc1 and I am not sure if it is better to search in the old omapdrm code what is missing now. Or to wait for your DSI code and just update/fix our panel driver (and have a chance to get that one upstream). BR and thanks, Nikolaus > > -- Sebastian > > Sebastian Reichel (56): > ARM: dts: omap: add channel to DSI panels > ARM: dts: omap4-droid4: add panel compatible > Revert "drm/omap: dss: Remove unused omap_dss_device operations" > omap/drm: drop unused dsi.configure_pins > drm/omap: dsi: use MIPI_DSI_FMT_* instead of OMAP_DSS_DSI_FMT_* > drm/omap: constify write buffers > drm/omap: dsi: add generic transfer function > drm/omap: panel-dsi-cm: convert to transfer API > drm/omap: dsi: unexport specific data transfer functions > drm/omap: dsi: drop virtual channel logic > drm/omap: dsi: simplify write function > drm/omap: dsi: simplify read functions > drm/omap: dsi: switch dsi_vc_send_long/short to mipi_dsi_msg > drm/omap: dsi: introduce mipi_dsi_host > drm/omap: panel-dsi-cm: use DSI helpers > drm/omap: dsi: request VC via mipi_dsi_attach > drm/omap: panel-dsi-cm: drop hardcoded VC > drm/omap: panel-dsi-cm: use common MIPI DCS 1.3 defines > drm/omap: dsi: drop unused memory_read() > drm/omap: dsi: drop unused get_te() > drm/omap: dsi: drop unused enable_te() > drm/omap: dsi: drop useless sync() > drm/omap: dsi: use pixel-format and mode from attach > drm/omap: panel-dsi-cm: use bulk regulator API > drm/omap: dsi: lp/hs switching support for transfer() > drm/omap: dsi: move TE GPIO handling into core > drm/omap: dsi: drop custom enable_te() API > drm/omap: dsi: do bus locking in host driver > drm/omap: dsi: untangle ulps ops from enable/disable > drm/dsi: add MIPI_DSI_MODE_ULPS_IDLE > drm/omap: dsi: do ULPS in host driver > drm/omap: dsi: move panel refresh function to host > drm/omap: dsi: Reverse direction of the DSS device enable/disable > operations > drm/omap: dsi: drop custom panel capability support > drm/omap: dsi: convert to drm_panel > drm/omap: drop omapdss-boot-init > drm/omap: dsi: implement check timings > drm/omap: panel-dsi-cm: use DEVICE_ATTR_RO > drm/omap: panel-dsi-cm: support unbinding > drm/omap: panel-dsi-cm: fix remove() > drm/omap: dsi: return proper error code from dsi_update_all() > drm/omap: remove global dss_device variable > drm/omap: bind components with drm_device argument > drm/panel: Move OMAP's DSI command mode panel driver > drm/omap: dsi: Register a drm_bridge > drm/omap: remove legacy DSS device operations > drm/omap: remove unused omap_connector > drm/omap: simplify omap_display_id > drm/omap: drop unused DSS next pointer > drm/omap: drop empty omap_encoder helper functions > drm/omap: drop DSS ops_flags > drm/omap: drop dssdev display field > drm/omap: simplify DSI manual update code > ARM: omap2plus_defconfig: Update for moved DSI command mode panel > drm/panel/panel-dsi-cm: support rotation property > ARM: dts: omap4-droid4: add panel orientation > > .../bindings/display/panel/panel-dsi-cm.txt | 4 +- > .../boot/dts/motorola-mapphone-common.dtsi | 6 +- > arch/arm/boot/dts/omap3-n950.dts | 3 +- > arch/arm/boot/dts/omap3.dtsi | 3 + > arch/arm/boot/dts/omap4-sdp.dts | 6 +- > arch/arm/boot/dts/omap4.dtsi | 6 + > arch/arm/boot/dts/omap5.dtsi | 6 + > arch/arm/configs/omap2plus_defconfig | 2 +- > drivers/gpu/drm/omapdrm/Kconfig | 1 - > drivers/gpu/drm/omapdrm/Makefile | 2 - > drivers/gpu/drm/omapdrm/displays/Kconfig | 10 - > drivers/gpu/drm/omapdrm/displays/Makefile | 2 - > .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 1387 ----------------- > drivers/gpu/drm/omapdrm/dss/Kconfig | 4 +- > drivers/gpu/drm/omapdrm/dss/Makefile | 2 - > drivers/gpu/drm/omapdrm/dss/base.c | 58 +- > drivers/gpu/drm/omapdrm/dss/dsi.c | 1034 +++++++----- > drivers/gpu/drm/omapdrm/dss/dss.c | 44 +- > .../gpu/drm/omapdrm/dss/omapdss-boot-init.c | 220 --- > drivers/gpu/drm/omapdrm/dss/omapdss.h | 141 +- > drivers/gpu/drm/omapdrm/dss/output.c | 13 +- > drivers/gpu/drm/omapdrm/dss/venc.c | 1 - > drivers/gpu/drm/omapdrm/omap_connector.c | 157 -- > drivers/gpu/drm/omapdrm/omap_connector.h | 28 - > drivers/gpu/drm/omapdrm/omap_crtc.c | 35 +- > drivers/gpu/drm/omapdrm/omap_drv.c | 49 +- > drivers/gpu/drm/omapdrm/omap_drv.h | 1 - > drivers/gpu/drm/omapdrm/omap_encoder.c | 59 +- > drivers/gpu/drm/panel/Kconfig | 9 + > drivers/gpu/drm/panel/Makefile | 1 + > drivers/gpu/drm/panel/panel-dsi-cm.c | 674 ++++++++ > include/drm/drm_mipi_dsi.h | 2 + > 32 files changed, 1465 insertions(+), 2505 deletions(-) > delete mode 100644 drivers/gpu/drm/omapdrm/displays/Kconfig > delete mode 100644 drivers/gpu/drm/omapdrm/displays/Makefile > delete mode 100644 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c > delete mode 100644 drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c > delete mode 100644 drivers/gpu/drm/omapdrm/omap_connector.c > delete mode 100644 drivers/gpu/drm/omapdrm/omap_connector.h > create mode 100644 drivers/gpu/drm/panel/panel-dsi-cm.c > > > base-commit: 54ba965bb3873eca6098ddf04e3a8d7bba1b5557 > -- > 2.25.0 >