Re: [PATCH] ARM: dts: am5729: beaglebone-ai: fix rgmii phy-mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 15/06/2020 15:45, Drew Fustini wrote:
On Mon, Jun 15, 2020 at 12:34:57PM +0300, Grygorii Strashko wrote:


On 12/06/2020 01:09, Drew Fustini wrote:
Since commit cd28d1d6e52e ("net: phy: at803x: Disable phy delay for
RGMII mode") the networking is broken on the BeagleBone AI which has
the AR8035 PHY for Gigabit Ethernet [0].  The fix is to switch from
phy-mode = "rgmii" to phy-mode = "rgmii-rxid".

Note: Grygorii Strashko made a similar phy-mode fix in 820f8a870f65 for
other AM5729 boards.

commit ref is incorrect

Do you mean commit ref 820f8a870f65 ?
("ARM: dts: am57xx: fix networking on boards with ksz9031 phy")

I thought it made sense to point to that commit as you seemed to be
fixing a very similar issue, just for a different phy.

Yes. but you should use proper format for commit ref:
commit <12+ chars of sha1> (\"<title line>\")'

checkpatch should warn you.




--
Best regards,
grygorii



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux