Hi Tony, I love your patch! Perhaps something to improve: [auto build test WARNING on omap/for-next] [also build test WARNING on balbi-usb/testing/next char-misc/char-misc-testing staging/staging-testing linus/master v5.7 next-20200529] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Tony-Lindgren/Suspend-and-resume-fixes-for-omapdrm-pdata-removal/20200601-050321 base: https://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git for-next config: arm-defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>, old ones prefixed by <<): drivers/bus/ti-sysc.c: In function 'sysc_wait_softreset': >> drivers/bus/ti-sysc.c:228:6: warning: variable 'sysc_offset' set but not used [-Wunused-but-set-variable] 228 | int sysc_offset, syss_offset, error = 0; | ^~~~~~~~~~~ vim +/sysc_offset +228 drivers/bus/ti-sysc.c 223 224 /* Poll on reset status */ 225 static int sysc_wait_softreset(struct sysc *ddata) 226 { 227 u32 sysc_mask, syss_done, rstval; > 228 int sysc_offset, syss_offset, error = 0; 229 230 sysc_offset = ddata->offsets[SYSC_SYSCONFIG]; 231 syss_offset = ddata->offsets[SYSC_SYSSTATUS]; 232 sysc_mask = BIT(ddata->cap->regbits->srst_shift); 233 234 if (ddata->cfg.quirks & SYSS_QUIRK_RESETDONE_INVERTED) 235 syss_done = 0; 236 else 237 syss_done = ddata->cfg.syss_mask; 238 239 if (syss_offset >= 0) { 240 error = readx_poll_timeout(sysc_read_sysstatus, ddata, rstval, 241 (rstval & ddata->cfg.syss_mask) == 242 syss_done, 243 100, MAX_MODULE_SOFTRESET_WAIT); 244 245 } else if (ddata->cfg.quirks & SYSC_QUIRK_RESET_STATUS) { 246 error = readx_poll_timeout(sysc_read_sysconfig, ddata, rstval, 247 !(rstval & sysc_mask), 248 100, MAX_MODULE_SOFTRESET_WAIT); 249 } 250 251 return error; 252 } 253 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
