* Arnd Bergmann <arnd@xxxxxxxx> [200529 22:01]: > There is one more regression introduced by the last build fix: > > arch/arm/mach-omap2/timer.c:170:6: error: attribute declaration must precede definition [-Werror,-Wignored-attributes] > void __init omap5_realtime_timer_init(void) > ^ > arch/arm/mach-omap2/common.h:118:20: note: previous definition is here > static inline void omap5_realtime_timer_init(void) > ^ > arch/arm/mach-omap2/timer.c:170:13: error: redefinition of 'omap5_realtime_timer_init' > void __init omap5_realtime_timer_init(void) > ^ > arch/arm/mach-omap2/common.h:118:20: note: previous definition is here > static inline void omap5_realtime_timer_init(void) > > As it turns out, the CONFIG_SOC_HAS_REALTIME_COUNTER option > should never be disabled for OMAP5 as we realy on this to initialize > the clocks and the timer. Just remove it here and make it the default. > > Removing the guard around the set_cntfreq() definition, I noticed that > this is not properly namespaced, so fix that as well. Looks good to me, thanks for fixing it: Acked-by: Tony Lindgren <tony@xxxxxxxxxxx>
