Hi Tony, Sorry about the late reply on this. On Thu, Apr 23, 2020 at 08:37:56AM -0700, Tony Lindgren wrote: > * Johan Hovold <johan@xxxxxxxxxx> [200423 11:44]: > > I know the location of this driver has been up for discussion already, > > but drivers/tty/serdev/protocol still isn't right (e.g. we don't have an > > drivers/i2c/protocol directory where we stuff random i2c client > > drivers). > > Argh, the location of driver again.. So we do have the custom motorola > layer to deal with on top of TS 27.010, but the custom handling is > contained within the driver. So maybe just drivers/serial for the > custom driver then. Yeah, that should do for now; n_gsm is a serial driver (exposing tty devices) after all. > > Last, it seems you've based the serdev-ngsm-motmdm.c chardev > > implementation on a more or less verbatim copy of drivers/gnss/core.c. > > I'd appreciate if you could mention that in the file header and > > reproduce the copyright notice if you end up keeping that interface. > > Oh yes indeed, thanks for pointing that out. I'll add it to the next > version. The chardev code is for sure based on drivers/gnss. > > To explain my ignorance, I added the chardev support initially as an > experiment to see if I can handle the motorola packet layer better > that way compared to the n_gsm ttys and userspace handling. It ended > up working quite nicely, so I kept it but then I accidentally left > out references to the source. Sorry about that. No worries. Johan
