On 27/04/2020 16:31, Tony Lindgren wrote: > Hi, > > * Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> [200427 09:19]: >> On 17/04/2020 18:55, Tony Lindgren wrote: >>> --- a/Documentation/devicetree/bindings/timer/ti,timer.txt >>> +++ b/Documentation/devicetree/bindings/timer/ti,timer.txt >>> @@ -14,6 +14,8 @@ Required properties: >>> ti,omap5430-timer (applicable to OMAP543x devices) >>> ti,am335x-timer (applicable to AM335x devices) >>> ti,am335x-timer-1ms (applicable to AM335x devices) >>> + ti,dmtimer-clockevent (when used as for clockevent) >>> + ti,dmtimer-clocksource (when used as for clocksource) >> >> Please, submit a separate patch for this. >> >> Before you resend as is, this will be nacked as clocksource / clockevent >> is not a hardware description but a Linux thing. >> >> Finding a way to characterize that from the DT is an endless discussion >> since years, so I suggest to use a single property for the timer eg >> <ti,dmtimer> and initialize the clocksource and the clockevent in the >> driver. > > Hmm good point. We still need to specify which timer is a clocksource > and which one a clockevent somehow. > > Maybe we could have a generic properties like the clock framework such as: > > assigned-system-clocksource > assigned-system-clockevent I think that will be the same problem :/ Is it possible to check the interrupt for the clockevent ? A timer node with the interrrupt is the clockevent, without it is a clocksource. -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
