* Suman Anna <s-anna@xxxxxx> [200212 21:36]: > Hi Tony, > > Do you have the history of why the 32 KHz source is set as parent during > prepare? One of the current side-affects of this patch is that now instead > of bailing out, the 32 KHz source is set, and consumers will still need > to select their appropriate parent. Dropping that call should actually > allow us to select the parents in the consumer nodes in dts files using > the assigned-clocks and assigned-clock-parents properties. I prefer to > drop it if you do not foresee any issues. For now, I do not anticipate > any issues with omap-pwm-dmtimer with this patch. Using the 32 KiHz source works better for PM. But yeah the machine specific source clock should be configured with assigned-clocks and assigned-clock-parents properites. Things seem to behave just fine for me with this patch for both pwm-leds and PM. Good to see this function gone: Tested-by: Tony Lindgren <tony@xxxxxxxxxxx>