Hi Sebastian, Thank you for the patch. On Tue, Feb 25, 2020 at 12:20:32AM +0100, Sebastian Reichel wrote: > Add Droid 4 specific compatible value in addition to the > generic one, so that we have the ability to add panel > specific quirks in the future. We need to document this compatible string in DT bindings, I don't think this is included in this series. Furthermore, could we use a compatible string that actually matches the panel vendor and model, instead of the device name ? > Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx> > --- > arch/arm/boot/dts/motorola-mapphone-common.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/motorola-mapphone-common.dtsi b/arch/arm/boot/dts/motorola-mapphone-common.dtsi > index a5e4ba7c8dab..622383ec6a75 100644 > --- a/arch/arm/boot/dts/motorola-mapphone-common.dtsi > +++ b/arch/arm/boot/dts/motorola-mapphone-common.dtsi > @@ -200,7 +200,7 @@ dsi1_out_ep: endpoint { > }; > > lcd0: panel@0 { > - compatible = "panel-dsi-cm"; > + compatible = "motorola,droid4-panel", "panel-dsi-cm"; > reg = <0>; > label = "lcd0"; > vddi-supply = <&lcd_regulator>; -- Regards, Laurent Pinchart