On Mon, Feb 24, 2020 at 10:51:33AM +0530, Lokesh Vutla wrote: > To configure DM timer is pwm mode the following needs to be set in > OMAP_TIMER_CTRL_REG using set_pwm callback: > - Set toggle mode on PORTIMERPWM output pin > - Set trigger on overflow and match on PORTIMERPWM output pin. > - Set auto reload > > This is a one time configuration and needs to be set before the start of > the dm timer. But the current driver tries to set the same configuration > for every period/duty cycle update, which is not needed. So move the pwm > setup before enabling timer and do not update it in pwm_omap_dmtimer_config. Is this change kind of moot with the conversion to .apply in the next patch? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
