On 12-02-20, 13:32, afzal mohammed wrote: > request_irq() is preferred over setup_irq(). Existing callers of > setup_irq() reached mostly via 'init_IRQ()' & 'time_init()', while > memory allocators are ready by 'mm_init()'. > > Per tglx[1], setup_irq() existed in olden days when allocators were not > ready by the time early interrupts were initialized. > > Hence replace setup_irq() by request_irq(). > > Seldom remove_irq() usage has been observed coupled with setup_irq(), > wherever that has been found, it too has been replaced by free_irq(). > > [1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos > > Signed-off-by: afzal mohammed <afzal.mohd.ma@xxxxxxxxx> > --- > arch/arm/mach-spear/time.c | 9 ++------- > > diff --git a/arch/arm/mach-spear/time.c b/arch/arm/mach-spear/time.c > index 289e036c9c30..92b2850eeb4f 100644 > --- a/arch/arm/mach-spear/time.c > +++ b/arch/arm/mach-spear/time.c > @@ -181,12 +181,6 @@ static irqreturn_t spear_timer_interrupt(int irq, void *dev_id) > return IRQ_HANDLED; > } > > -static struct irqaction spear_timer_irq = { > - .name = "timer", > - .flags = IRQF_TIMER, > - .handler = spear_timer_interrupt > -}; > - > static void __init spear_clockevent_init(int irq) > { > u32 tick_rate; > @@ -201,7 +195,8 @@ static void __init spear_clockevent_init(int irq) > > clockevents_config_and_register(&clkevt, tick_rate, 3, 0xfff0); > > - setup_irq(irq, &spear_timer_irq); > + if (request_irq(irq, spear_timer_interrupt, IRQF_TIMER, "timer", NULL)) > + pr_err("request_irq() on %s failed\n", "timer"); > } Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx> -- viresh
