Hi, On 08/02/2020 20:18, Merlijn Wajer wrote: > Hi, > > On 08/02/2020 20:04, Pavel Machek wrote: >> Hi! >> >>> When booting Linux 5.4.18 with omap2plus_defconfig, I no longer get a >>> /dev/mmcblk0 device - the one corresponding to my microSD card, where >>> u-boot also loads the kernel from. >>> >>> This also likely seems to be a regression, but I haven't tried to hunt >>> it down yet. >>> >>> Kernel log attached, below. >> >> Do you have back cover attached? That's common trap... > > Right. > > No, I did not, since I have the serial pins connected to my PC, and the > whole device is mounted on a piece of hardware for that. I thought that > we fixed the problem where we require the cover to be on... Indeed, this was the problem. Is there really a reason to have this in the DTS? I have a hard time imagining a use case for not showing SD card to users or developers simply because the casing is open. If anything, this sounds like it should be a userspace thing. That said, any opposition to a patch to invert the logic - have users or developers specifically enable some code to *not* show the MMC card when the cover is open? Or perhaps just outright remove the check in the kernel? How about something like the patch below (which we currently ship)? Cheers, Merlijn From 9ce9bb2557208bb347909823d4710c9f93f65bf0 Mon Sep 17 00:00:00 2001 From: Arthur Demchenkov <spinal.by@xxxxxxxxx> Date: Mon, 25 Mar 2019 01:44:23 +0300 Subject: [PATCH] ARM: dts: n900: ignore mmc1 card detect gpio Allow the device to boot from external MMC with back cover removed. See https://github.com/maemo-leste/bugtracker/issues/225 --- arch/arm/boot/dts/omap3-n900.dts | 4 ---- 1 file changed, 4 deletions(-) diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts index 7028a7cb2849e..03481302704de 100644 --- a/arch/arm/boot/dts/omap3-n900.dts +++ b/arch/arm/boot/dts/omap3-n900.dts @@ -805,10 +805,6 @@ pinctrl-0 = <&mmc1_pins>; vmmc-supply = <&vmmc1>; bus-width = <4>; - /* For debugging, it is often good idea to remove this GPIO. - It means you can remove back cover (to reboot by removing - battery) and still use the MMC card. */ - cd-gpios = <&gpio6 0 GPIO_ACTIVE_LOW>; /* 160 */ }; /* most boards use vaux3, only some old versions use vmmc2 instead */
Attachment:
signature.asc
Description: OpenPGP digital signature
