[bug report] omapfb: copy omapdss & displays for omapfb

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Tomi Valkeinen,

The patch f76ee892a99e: "omapfb: copy omapdss & displays for omapfb"
from Dec 9, 2015, leads to the following static checker warning:

	drivers/video/fbdev/omap2/omapfb/dss/display-sysfs.c:336 display_uninit_sysfs()
	warn: passing freed memory 'dssdev'

drivers/video/fbdev/omap2/omapfb/dss/display-sysfs.c
   332  void display_uninit_sysfs(struct platform_device *pdev)
   333  {
   334          struct omap_dss_device *dssdev = NULL;
   335  
   336          for_each_dss_dev(dssdev) {
   337                  if (kobject_name(&dssdev->kobj) == NULL)
   338                          continue;
   339  
   340                  kobject_del(&dssdev->kobj);
   341                  kobject_put(&dssdev->kobj);
   342  
   343                  memset(&dssdev->kobj, 0, sizeof(dssdev->kobj));

Depending on the config options kobject_release() might delay clean up
for 1-4 seconds so this memset() could lead to bugs.

   344          }
   345  }

regards,
dan carpenter



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux