On Thu, Jan 30, 2020 at 7:09 PM Suman Anna <s-anna@xxxxxx> wrote: > On 1/30/20 9:34 AM, Andy Shevchenko wrote: > > On Tue, Jan 28, 2020 at 1:14 AM Suman Anna <s-anna@xxxxxx> wrote: ... > >> - syscon_config.name = of_node_full_name(np); > >> + syscon_config.name = kasprintf(GFP_KERNEL, "%pOFn@%llx", np, > >> + (u64)res.start); > > > > Explicit castings in printf() usually tell us that something is not okay. > > Yes, I agree in general. > > > Yes, for resource_size_t we have %pa. > > And that was the first thing I tried when doing v2, before moving away > from it. This is not for a console printf statement, but is rather for > the regmap debugfs name. Using a %pa adds the 0x and leading zeros in > the debugfs name, when compared to the name before this patch. The > typecast retains the current format, and replaces the unit-address > without the leading 0s either. Introducing a local-variable to avoid the > typecast is overkill. Thanks for the clarification. -- With Best Regards, Andy Shevchenko
