Re: [PATCH 4/4] I2C: OMAP3: PM: (re)init for every transfer to support off-mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

Kevin Hilman wrote:
> From: Rajendra Nayak <rnayak@xxxxxx>
>
> Because of OMAP off-mode, powerdomain can go off when I2C is idle.
> Save enough state, and do a re-init for each transfer.
>
> Additional save/restore state added by Jagadeesh Bhaskar Pakaravoor
> (SYSC_REG) and Aaro Koskinen (wakeup sources.)
>
> Signed-off-by: Jouni Hogander <jouni.hogander@xxxxxxxxx>
> Signed-off-by: Rajendra Nayak <rnayak@xxxxxx>
> Cc: Jagadeesh Bhaskar Pakaravoor <j-pakaravoor@xxxxxx>
> Cc: Aaro Koskinen <aaro.koskinen@xxxxxxxxx>
> Signed-off-by: Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx>

This patch introduces a compiler warning:

  CC      drivers/i2c/busses/i2c-omap.o
drivers/i2c/busses/i2c-omap.c: In function 'omap_i2c_init':
drivers/i2c/busses/i2c-omap.c:303: warning: unused variable 'v'

So the declaration of "v" should be also removed here:

> @@ -289,21 +302,22 @@ static int omap_i2c_init(struct omap_i2c_dev *dev)
>  		} else if (dev->rev >= OMAP_I2C_REV_ON_3430) {
>  			u32 v;
>
> -			v = SYSC_AUTOIDLE_MASK;
> -			v |= SYSC_ENAWAKEUP_MASK;
> -			v |= (SYSC_IDLEMODE_SMART <<
> +			dev->syscstate = SYSC_AUTOIDLE_MASK;
> +			dev->syscstate |= SYSC_ENAWAKEUP_MASK;
> +			dev->syscstate |= (SYSC_IDLEMODE_SMART <<

A.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux