Re: [PATCH 2/3] spi: spi-ti-qspi: support large flash devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 11, 2019 at 08:39:53PM +0100, Jean Pihet wrote:

> +			if (op->addr.val + op->data.nbytes > qspi->mmap_size) {
> +				max_len = qspi->mmap_size - op->addr.val;
> +				op->data.nbytes = min(op->data.nbytes, max_len);
> +			}

This introduces a massive warning splat for me (just one warning but
it's very verbose):

  CC      drivers/spi/spi-ti-qspi.o
In file included from drivers/spi/spi-ti-qspi.c:9:
drivers/spi/spi-ti-qspi.c: In function ‘ti_qspi_adjust_op_size’:
./include/linux/kernel.h:844:29: warning: comparison of distinct pointer types lacks a cast
   (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
                             ^~
./include/linux/kernel.h:858:4: note: in expansion of macro ‘__typecheck’
   (__typecheck(x, y) && __no_side_effects(x, y))
    ^~~~~~~~~~~
./include/linux/kernel.h:868:24: note: in expansion of macro ‘__safe_cmp’
  __builtin_choose_expr(__safe_cmp(x, y), \
                        ^~~~~~~~~~
./include/linux/kernel.h:877:19: note: in expansion of macro ‘__careful_cmp’
 #define min(x, y) __careful_cmp(x, y, <)
                   ^~~~~~~~~~~~~
drivers/spi/spi-ti-qspi.c:535:23: note: in expansion of macro ‘min’
     op->data.nbytes = min(op->data.nbytes, max_len);
                       ^~~
./include/linux/kernel.h:844:29: warning: comparison of distinct pointer types lacks a cast
   (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
                             ^~
./include/linux/kernel.h:858:4: note: in expansion of macro ‘__typecheck’
   (__typecheck(x, y) && __no_side_effects(x, y))
    ^~~~~~~~~~~
./include/linux/kernel.h:868:24: note: in expansion of macro ‘__safe_cmp’
  __builtin_choose_expr(__safe_cmp(x, y), \
                        ^~~~~~~~~~
./include/linux/kernel.h:877:19: note: in expansion of macro ‘__careful_cmp’
 #define min(x, y) __careful_cmp(x, y, <)
                   ^~~~~~~~~~~~~
drivers/spi/spi-ti-qspi.c:545:22: note: in expansion of macro ‘min’
    op->data.nbytes = min(op->data.nbytes, max_len);
                      ^~~

Using compilers from Debian stable.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux