> >>> diff --git a/arch/arm/mach-omap2/smartreflex.c
> >>> b/arch/arm/mach-omap2/smartreflex.c
> >>> index 9d462e3..bacf602 100644
> >>> --- a/arch/arm/mach-omap2/smartreflex.c
> >>> +++ b/arch/arm/mach-omap2/smartreflex.c
> >>> @@ -52,6 +52,8 @@ struct omap_sr {
> >>>
> >>> #define SR_REGADDR(offs) (sr->srbase_addr + offset)
> >>>
> >>> +static omap3_voltagescale_vcbypass_t omap3_volscale_vcbypass_fun;
> >>>
> >>>
> >> Perhaps use
> >> static int (*omap3_volscale_vcbypass_fun) (u32, u32, u8, u8);
> >>
> >> This gets rid of the compiler warning on incompatible pointer
> >> types when
> >> you register a function via omap3_voltagescale_vcbypass_setup().
> >>
> >> -- Mike
> >>
> > Thanks Mike, but we do not see the warnning with the original
> > Code, note this patch is slightly different with the one we sent
> > To you based on K29, this new patch have four parameters
> > Sinc some change has been made in the
> > sr_voltagescale_vcbypass to add two more parameters.
> >
> > Is your warnning caused by this?
> >
> >
>
> This patch stand-alone doesn't give me any warnings. Its only when you
> hook into this from your board file. Might be the compiler I'm using.
> I used this patch + modified version of the patches you sent me before
> to get the two working. (Yes, 4 params).
I just verified the change on both current linux-omap pm branch and
The branch we are using, neither of them reports any warnning.
Just reminder, the patch I sent to you are different in all these files,
Since we should use 2 params in our kernel, the patch I sent to
This list has 4 params. Please check whether the warnning
Is caused by the mismatch in the function declaration and
The function definition in the board file.
It should not cause the warning even you are using different
Compiler.
>
> -- MIke
> > Thanks,
> > Chunqiu
> >
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
