On 09/12/2019 16:50, Laurent Pinchart wrote: > Hi Jyri, > > Thank you for the patch. > > On Mon, Dec 09, 2019 at 04:42:15PM +0200, Jyri Sarha wrote: >> The "ti,tilcdc,panel" binding should not be used anymore, since tilcdc >> is fully capable of using generic drm panels like panel-simple and >> panel-common binding. However, the obsolete binding is still widely >> used in many mainline supported platforms that I do not have access to >> and who knows how many custom platforms. So I am afraid we have to >> keep the old bundled tilcdc panel driver around. > > But can't we drop the bindings instead of marking them as obsolete, even > if we keep the driver around for some time ? > I guess that would be alright too. > Also, would it make sense to set a date for the removal of the driver, > and add it to the WARN() message in patch 3/3 ? > Not sure about a date. I would feel quite uncomfortable of removing the driver, while there is still mainline DTSes using "ti,tilcdc,panel". I guess the next step would be putting the legacy panel driver behind a default = N config option. Then I would probably hear something if there are people actively using those DTSes. Maybe the date could be about that too. BR, Jyri >> Signed-off-by: Jyri Sarha <jsarha@xxxxxx> >> --- >> Documentation/devicetree/bindings/display/tilcdc/panel.txt | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/display/tilcdc/panel.txt b/Documentation/devicetree/bindings/display/tilcdc/panel.txt >> index 808216310ea2..54963f9173cc 100644 >> --- a/Documentation/devicetree/bindings/display/tilcdc/panel.txt >> +++ b/Documentation/devicetree/bindings/display/tilcdc/panel.txt >> @@ -1,5 +1,11 @@ >> Device-Tree bindings for tilcdc DRM generic panel output driver >> >> +NOTE: This binding (and the related driver) is obsolete and should not >> + be used anymore. Please refer to drm panel-common binding (and >> + to a generic drm panel driver like panel-simple). >> + Documentation/devicetree/bindings/display/panel/panel-common.yaml >> + (drivers/gpu/drm/panel/panel-simple.c) >> + >> Required properties: >> - compatible: value should be "ti,tilcdc,panel". >> - panel-info: configuration info to configure LCDC correctly for the panel > -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
