Kevin Hilman wrote:
Jon Hunter <jon-hunter@xxxxxx> writes:
From: Jon Hunter <jon-hunter@xxxxxx>
There are two scenarios where a race condition could result in a hang in the
prcm_interrupt handler. These are:
IIRC, the RX51 tree has a workaround for some hangs seen in this
interrupt handler as well, so this has definitely been seen. The fix
there though was just to no loop, I think your fix is more thorough
and fixes the root cause. Thanks.
No comments on the funtional changes, but a couple
cosmetic/documentation changes.
1) Would it be possible to summarize the requirements in the function
itself as part of this patch.
Absolutely. I will add some comments.
2) With the extra indentation, this function is getting too indented.
Looking closer, an abstraction of the 'enable clocks, poll PM_WKST,
disable clocks loop' could be done an called with the various modules
and offsets. I've attached a hack/patch below to show what I mean.
You could just fold this into your patch.
Yes that makes a lot of sense. I did not like the fact it was becoming
difficult to read with the extra indentation. I will re-work this and
get you something in the next couple days.
Thanks for the feedback.
Cheers
Jon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
