Hi Jyri,
Thank you for the patch.
On Mon, Dec 09, 2019 at 04:42:16PM +0200, Jyri Sarha wrote:
> Add WARN() to the beginnig of tilcdc-panel probe. The obsolete
s/beginnig/beginning/
> tilcdc-panel driver should not be used anymore, since tilcdc is fully
> capable of using generic drm panels like panel-simple and panel-common
> binding.
>
> Signed-off-by: Jyri Sarha <jsarha@xxxxxx>
> ---
> drivers/gpu/drm/tilcdc/tilcdc_panel.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> index 5584e656b857..cf8e2462a524 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> @@ -309,6 +309,16 @@ static int panel_probe(struct platform_device *pdev)
> struct pinctrl *pinctrl;
> int ret;
>
> + /*
> + * The obsolete tilcdc-panel driver should not be used
> + * anymore, since tilcdc is fully capable of using generic drm
> + * panels like panel-simple and panel-common binding.
Indentation should use tabs.
> + */
> +
> + WARN(true,
> + "tilcdc-panel is obsolte and should not be used. Please update your configuration!\n",
s/obsolte/obsolete/ or deprecated ?
You may want to explicitly state what it should be updated to :-)
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> + dev_name(&pdev->dev));
> +
> /* bail out early if no DT data: */
> if (!node) {
> dev_err(&pdev->dev, "device-tree data is missing\n");
--
Regards,
Laurent Pinchart
