<snip> > > > >> > >> static void __init usb_musb_pm_init(void) > >> { > >>- /* Ensure force-idle mode for OTG controller */ > >>- if (cpu_is_omap34xx()) > >>- omap_writel(0, OTG_SYSCONFIG); > >>+ struct clk *iclk; > >>+ void __iomem *otg_base; > >>+ > >>+ if (!cpu_is_omap34xx()) > >>+ return; > > > > Why is this sys-config reset done only for omap34xx() > > This should be valid for any old 24xx() as well as new 44xx() omaps > Minor correction - it's valid only for any old 243x() only. 242x did not have this controller, IIRC. > You're correct. Good catch. > > The force-idle "fix" that this is replacing was only being done on > 34xx due to the smart-idle errata. However, this reset should be > done even without any errata. > > Thanks for review, will respin. > > Kevin > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html