On Thu, Oct 17, 2019 at 03:25:48PM +0300, Tero Kristo wrote:
> Currently crypto_wait_req waits indefinitely for an async crypto request
> to complete. This is bad as it can cause for example the crypto test
> manager to hang without any notification as to why it has happened.
> Instead of waiting indefinitely, add a 1 second timeout to the call,
> and provide a warning print if a timeout happens.
>
> Signed-off-by: Tero Kristo <t-kristo@xxxxxx>
> ---
> include/linux/crypto.h | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/crypto.h b/include/linux/crypto.h
> index 19ea3a371d7b..b8f0e5c3cc0c 100644
> --- a/include/linux/crypto.h
> +++ b/include/linux/crypto.h
> @@ -682,8 +682,15 @@ static inline int crypto_wait_req(int err, struct crypto_wait *wait)
> switch (err) {
> case -EINPROGRESS:
> case -EBUSY:
> - wait_for_completion(&wait->completion);
> + err = wait_for_completion_timeout(&wait->completion,
> + msecs_to_jiffies(1000));
> reinit_completion(&wait->completion);
> + if (!err) {
> + pr_err("%s: timeout for %p\n", __func__, wait);
> + err = -ETIMEDOUT;
> + break;
> + }
> +
> err = wait->err;
> break;
> };
I'm not sure this is a good idea, because operations could legitimately take a
long time, e.g. if someone passes in a huge data buffer. How do you know that X
amount of time is always going to be enough?
- Eric
