Hi Rob,
Thank you for you review and sorry for delay - I seems missed your mail and found it only now
while preparing new version of the series (v5).
On 10/07/2019 01:48, Rob Herring wrote:
On Fri, Jun 21, 2019 at 09:13:08PM +0300, Grygorii Strashko wrote:
Add bindings for the new TI CPSW switch driver. Comparing to the legacy
bindings (net/cpsw.txt):
- ports definition follows DSA bindings (net/dsa/dsa.txt) and ports can be
marked as "disabled" if not physically wired.
- ports definition follows DSA bindings (net/dsa/dsa.txt) and ports can be
marked as "disabled" if not physically wired.
- all deprecated properties dropped;
- all legacy propertiies dropped which represents constant HW cpapbilities
(cpdma_channels, ale_entries, bd_ram_size, mac_control, slaves,
active_slave)
- cpts properties grouped in "cpts" sub-node
Signed-off-by: Grygorii Strashko <grygorii.strashko@xxxxxx>
---
.../bindings/net/ti,cpsw-switch.txt | 147 ++++++++++++++++++
1 file changed, 147 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/ti,cpsw-switch.txt
diff --git a/Documentation/devicetree/bindings/net/ti,cpsw-switch.txt b/Documentation/devicetree/bindings/net/ti,cpsw-switch.txt
new file mode 100644
index 000000000000..787219cddccd
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/ti,cpsw-switch.txt
@@ -0,0 +1,147 @@
+TI SoC Ethernet Switch Controller Device Tree Bindings (new)
+------------------------------------------------------
+
+The 3-port switch gigabit ethernet subsystem provides ethernet packet
+communication and can be configured as an ethernet switch. It provides the
+gigabit media independent interface (GMII),reduced gigabit media
+independent interface (RGMII), reduced media independent interface (RMII),
+the management data input output (MDIO) for physical layer device (PHY)
+management.
+
+Required properties:
+- compatible : be one of the below:
+ "ti,cpsw-switch" for backward compatible
+ "ti,am335x-cpsw-switch" for AM335x controllers
+ "ti,am4372-cpsw-switch" for AM437x controllers
+ "ti,dra7-cpsw-switch" for DRA7x controllers
+- reg : physical base address and size of the CPSW module IO range
+- ranges : shall contain the CPSW module IO range available for child devices
+- clocks : should contain the CPSW functional clock
+- clock-names : should be "fck"
+ See bindings/clock/clock-bindings.txt
+- interrupts : should contain CPSW RX, TX, MISC, RX_THRESH interrupts
+- interrupt-names : should contain "rx_thresh", "rx", "tx", "misc"
What's the defined order because it's not consistent here.
fixed.
I've fixed mostly all your comments, just some clarifications below.
+ See bindings/interrupt-controller/interrupts.txt
+
+Optional properties:
+- syscon : phandle to the system control device node which provides access to
...
+ - local-mac-address : See [1]
+
+- mdio : CPSW MDIO bus block description
+ - bus_freq : MDIO Bus frequency
+ See bindings/net/mdio.txt and davinci-mdio.txt
Standard properties clock-frequency or bus-frequency would have been
better...
Davinci MDIO driver and its bindings are reused here as is.
So I'd like to avoid such changes here, but if you think it's right, I can try add
bus-frequency to standard MDIO bindings (mdio.yaml) as separate change.
+
+- cpts : The Common Platform Time Sync (CPTS) module description
+ - clocks : should contain the CPTS reference clock
+ - clock-names : should be "cpts"
+ See bindings/clock/clock-bindings.txt
+
+ Optional properties - all ports:
+ - cpts_clock_mult : Numerator to convert input clock ticks into ns
+ - cpts_clock_shift : Denominator to convert input clock ticks into ns
+ Mult and shift will be calculated basing on CPTS
+ rftclk frequency if both cpts_clock_shift and
+ cpts_clock_mult properties are not provided.
Should have 'ti' prefix and use '-' rather than '_'. However, these are
already defined somewhere else, right? I can't tell that from reading
this.
The same here - CPTS is reused here.
+
+[1] See Documentation/devicetree/bindings/net/ethernet.txt
+
+Examples - SOC:
[...]
--
Best regards,
grygorii
