> Am 06.09.2019 um 19:24 schrieb Tony Lindgren <tony@xxxxxxxxxxx>: > > * H. Nikolaus Schaller <hns@xxxxxxxxxxxxx> [190906 17:09]: > >> BTW there is also some code that does special SoC detection based on >> soc_device_match(), mainly in omapdrm/dss. >> >> If we were to use this mechanism in the ti-cpufreq driver we could >> match it to ti,omap3 and could avoid all these changes. >> >> But make it less maintainable and code more complex. > > Hmm right, yeah using soc_device_match() would remove this issue. > It might be worth doing as these SoC variants do not change > much and the code should not need updating. Up to you to > decide. I have looked through the structure of the ti-cpufreq driver but it assumes that each set of register offsets and bit masks has its own compatible so that it can just switch descriptor tables. There is no provision to run soc_device_match() instead. So let's forget this idea... BR, Nikolaus
