* Grygorii Strashko <grygorii.strashko@xxxxxx> [190903 12:46]: > > The clock definition itself looks fine, however the question is why does someone try to disable it while it > is apparently still used (by NFS that is)? If it fails to disable, clock core is trying to disable it, but the IDLEST bit does not switch for some reason. > > I've tried to disable "ti,no-idle" in DT for dra7 cpsw and got below failure > > [ 0.634530] gmac-clkctrl:0000:0: failed to enable 08070002 > [ 0.634557] ti-sysc: probe of 48485200.target-module failed with error -16 > > so samthing is not right with GMAC clocks as it should probe without "ti,no-idle". > > > original place of the issue is: > > cpsw_probe() > -> pm_runtime_get_sync() > -> sysc_runtime_resume() > -> sysc_enable_main_clocks() > > Note. the sysc_init_module() for "ti,no-idle" case looks a little bit strange as there is > no guarantee that target-module or clock were enabled before. Good point on the "ti,no-idle" handling. That is easy to fix by always enabling the clocks. The "ti,no-idle-on-init" handling needs probably a flag set for PM runtime. Regards, Tony
