Re: Charging voltage for droid4 battery

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Tony Lindgren <tony@xxxxxxxxxxx> [190826 23:13]:
> * Pavel Machek <pavel@xxxxxx> [190825 09:28]:
...

> > > > +++ b/drivers/power/supply/cpcap-charger.c
> > > > @@ -440,7 +440,7 @@ static void cpcap_usb_detect(struct work_struct *work)
> > > >  			max_current = CPCAP_REG_CRM_ICHRG_0A532;
> > > >  
> > > >  		error = cpcap_charger_set_state(ddata,
> > > > -						CPCAP_REG_CRM_VCHRG_4V35,
> > > > +						CPCAP_REG_CRM_VCHRG_4V20,
> > > >  						max_current, 0);
> > > >  		if (error)
> > > >  			goto out_err;
> > > > 
> > > 
> > > So I think you also need to change the battery full to 4.2V too? Sure
> > > if Android charged to 4.35V, we show 15 minutes of over 100%..
> > 
> > Umm. I am not sure I need to change anything else _in the kernel_?
> 
> It's just the battery .info.voltage_max_design that I'm wondering
> about. But then again, that should be battery specific and we don't
> need to care about that for the initial fix.

Well since we don't have anything in place for capacity right now,
no need to worry about the battery configured voltage right now.

So for your one liner fix above:

Acked-by: Tony Lindgren <tony@xxxxxxxxxxx>

Sebastian may want you to resend that with proper description?

Regards,

Tony



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux