On 27/08/2019 18:50, Aaro Koskinen wrote:
Hi,
On Tue, Aug 27, 2019 at 10:11:20AM +0200, Pali Rohár wrote:
On Monday 26 August 2019 11:00:21 Tero Kristo wrote:
On 24.8.2019 0.46, Aaro Koskinen wrote:
I was looking at N900 boot logs from the current mainline (v5.3-rc),
and noticed this:
[ 3.297668] omap3_rom_rng: initializing
[ 3.301940] omap3_rom_rng: unable to get RNG clock
[ 3.307006] omap3-rom-rng: probe of omap3-rom-rng failed with error -2
It seems some clock data was deleted with 0ed266d7ae5e ("clk: ti: omap3:
cleanup unnecessary clock aliases"), including one for omap3-rom-rng.
How this driver is supposed to work now? I guess it has been broken for
a while. :-(
You should have a DT node for the device, which contains the clock handle.
Hello, I have not tested new kernel on N900 for a longer time. And at
that time (4.9) it worked fine. So it is just missing DT node? Maybe you
could fix it when you testing it?
The driver does not seem to have DT support, it has only legacy init in
pdata-quirks. So maybe deleting the clock alias was premature.
It would be highly preferable to convert the driver out of legacy mode
then. Especially in this case where nobody cared about this going
missing for two years; it was one of the main points to ditch the clock
aliases so that we would notice the legacy drivers around.
-Tero
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
