On Tue, Aug 27, 2019 at 3:12 AM Pali Rohár <pali.rohar@xxxxxxxxx> wrote: > > On Monday 26 August 2019 11:00:21 Tero Kristo wrote: > > On 24.8.2019 0.46, Aaro Koskinen wrote: > > > Hi, > > > > > > I was looking at N900 boot logs from the current mainline (v5.3-rc), > > > and noticed this: > > > > > > [ 3.297668] omap3_rom_rng: initializing > > > [ 3.301940] omap3_rom_rng: unable to get RNG clock > > > [ 3.307006] omap3-rom-rng: probe of omap3-rom-rng failed with error -2 > > > > > > It seems some clock data was deleted with 0ed266d7ae5e ("clk: ti: omap3: > > > cleanup unnecessary clock aliases"), including one for omap3-rom-rng. > > > How this driver is supposed to work now? I guess it has been broken for > > > a while. :-( > > > > You should have a DT node for the device, which contains the clock handle. I am interested in enabling the RNG too, because sshd takes a long time to initialize without the hwrng. I am not able to find addresses in either the DM3730 TRM nor the OMAP3530 TRM. Can someone from TI make a recommendation as to what the node address should be? Having this would be a nice starting point. Also looking at the other omap RNG nodes there are references to hwmods, but looking at the platdata in pdata quirks, I am not seeing anything. There is also chunks of code that exist insdie arch/mach-omap2/omap-secure.c which appear to only be referenced from this driver, so I wonder if there might be some way to combine/condense this once it's been converted to device tree and functional again. adam > > Hello, I have not tested new kernel on N900 for a longer time. And at > that time (4.9) it worked fine. So it is just missing DT node? Maybe you > could fix it when you testing it? > > -- > Pali Rohár > pali.rohar@xxxxxxxxx