Hi Tero,
On 8/19/19 4:28 AM, Tero Kristo wrote:
> On 08/08/2019 07:35, Keerthy wrote:
>>
>>
>> On 07/08/19 1:18 PM, Tero Kristo wrote:
>>> Add new binding for OMAP PRM (Power and Reset Manager) instances. Each
>>> of these will act as a power domain controller and potentially as a
>>> reset
>>> provider.
>>>
>>> Signed-off-by: Tero Kristo <t-kristo@xxxxxx>
>>> ---
>>> .../devicetree/bindings/arm/omap/prm-inst.txt | 24
>>> ++++++++++++++++++++++
>>> 1 file changed, 24 insertions(+)
>>> create mode 100644
>>> Documentation/devicetree/bindings/arm/omap/prm-inst.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/omap/prm-inst.txt
>>> b/Documentation/devicetree/bindings/arm/omap/prm-inst.txt
>>> new file mode 100644
>>> index 0000000..e0ae87b
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/arm/omap/prm-inst.txt
>>> @@ -0,0 +1,24 @@
>>> +OMAP PRM instance bindings
>>> +
>>> +Power and Reset Manager is an IP block on OMAP family of devices which
>>> +handle the power domains and their current state, and provide reset
>>> +handling for the domains and/or separate IP blocks under the power
>>> domain
>>> +hierarchy.
So, I see that you are adding these as flat nodes directly under the prm
nodes where we have the clocks and clock_domains. Are you anticipating a
single DT node and/or driver managing both power-domains and resets?
>>> +
>>> +Required properties:
>>> +- compatible: Must be one of:
>>> + "ti,am3-prm-inst"
>>> + "ti,am4-prm-inst"
>>> + "ti,omap4-prm-inst"
>>> + "ti,omap5-prm-inst"
>>> + "ti,dra7-prm-inst"
What about OMAP2, OMAP3, DM814x, DM816x?
regards
Suman
>>> +- reg: Contains PRM instance register address range
>>> + (base address and length)
>>
>> How about reset-cells property, Isn't that a mandatory property?
>
> It is optional, but you are right, should be added to this.
>
> -Tero
>
>>
>>> +
>>> +Example:
>>> +
>>> +prm_dsp2: prm@1b00 {
>>> + compatible = "ti,dra7-prm-inst";
>>> + reg = <0x1b00 0x40>;
>>> + #reset-cells = <1>;
>>> +};
>>>
>
> --
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
