Hi, On Thu, Aug 08, 2019 at 03:19:50PM -0700, Dmitry Torokhov wrote: > On Thu, Aug 08, 2019 at 11:46:45PM +0200, Arnd Bergmann wrote: > > On Thu, Aug 8, 2019 at 11:43 PM Dmitry Torokhov wrote: > > > On Thu, Aug 08, 2019 at 11:22:22PM +0200, Arnd Bergmann wrote: > > > > By using the new linux/soc/ti/omap1-io.h header instead, > > > > compile-testing can be enabled, and a CONFIG_ARCH_MULTIPLATFORM > > > > conversion of omap1 may eventually be possible. > > > > > > > > The warning in the header file gets removed in order to > > > > allow CONFIG_COMPILE_TEST. > > > > > > Given that we want to migrate people off this driver everywhere but > > > OMAP1 I wonder why we would want to improve compile coverage of it. > > > > Mainly for consistency: I'm converting all omap1 drivers in this series to > > not rely on mach/* headers and to let them be compiled standalone. > > The other drivers don't have a replacement, so I could treat this different > > from the rest and skip the Kconfig and platform_data changes if you > > prefer. > > Yes, because at least with the version you posted we are losing the > #warning telling people to move to matrix_keypad. We could do: > > #ifndef CONFIG_COMPILE_TEST > #warning ... > #endif > > if you really want to allow compiling standalone for testing. FWIW the driver depends on ARCH_OMAP1 and the warning is only printed for !ARCH_OMAP1. In other words: The warning is never printed at the moment. All OMAP2+ boards moved to matrix-keypad long time ago and the driver does not support OMAP2+ anymore since f799a3d8fe170 from 2012. -- Sebastian
Attachment:
signature.asc
Description: PGP signature
