Lorenzo, On 11/06/19 10:08 AM, Kishon Vijay Abraham I wrote: > Hi Rob, > > On 10/06/19 11:13 PM, Rob Herring wrote: >> On Tue, Jun 4, 2019 at 7:19 AM Kishon Vijay Abraham I <kishon@xxxxxx> wrote: >>> >>> Export of_platform_device_create_pdata() to be used by drivers to >>> create child devices with the given platform data. This can be used >>> by platform specific driver to send platform data core driver. For e.g., >>> this will be used by TI's J721E SoC specific PCIe driver to send >>> ->start_link() ops and ->is_link_up() ops to Cadence core PCIe driver. >> >> NAK >> >> of_platform_device_create_pdata() is purely for legacy handling of >> auxdata which is something I hope to get rid of someday. Or to put it >> another way, auxdata use is a sign of platforms not fully converted to >> DT. > > All right. Thanks for letting me know your thoughts. > > Lorenzo, > > We've modeled Cadence PCIe core as a separate driver and for some of the > functionalities (for example starting LTSSM or checking link status) it has to > invoke the wrapper driver functions (The registers for these are present in > wrapper and not in Cadence Core). In the case of Designware, we modeled DWC > core as a library which provided APIs to be used by wrapper driver. Now that > Rob is not inclined for passing platform data from one driver to another (in > this case TI specific J721E driver to Cadence PCIe driver), should we model > Cadence core also as a library? If you agree, I can prepare patches for making > Cadence PCIe core as a library. Please let me know your thoughts. Can you share your thoughts on this? Thanks Kishon
