On 27-06-19, 23:02, Daniel Lezcano wrote: > It looks like after the changes in the patch the only reason for > returning (struct thermal_cooling_device *) from > cpufreq_cooling_register() is error checking, but it would be much > more straightforward to return int for this purpose. > > Moreover, that would prevent the callers of it from doing incorrect > things with the returned pointers (like using it to unregister the > cooling device). > > Replace the returned value an integer instead of a pointer to a > thermal cooling device structure. > > Suggested-by: Rafael J. Wysocki <rafael@xxxxxxxxxx> > Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> > --- > drivers/thermal/cpu_cooling.c | 63 +++++++++---------- > drivers/thermal/imx_thermal.c | 6 +- > .../ti-soc-thermal/ti-thermal-common.c | 7 +-- > include/linux/cpu_cooling.h | 16 ++--- > 4 files changed, 40 insertions(+), 52 deletions(-) Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx> -- viresh
