On Mon, 17 Jun 2019 12:40:48 +0100 Mark Brown <broonie@xxxxxxxxxx> wrote: > On Mon, Jun 17, 2019 at 01:03:57PM +0200, Andreas Kemnade wrote: > > Mark Brown <broonie@xxxxxxxxxx> wrote: > > > On Sat, Jun 15, 2019 at 06:33:14PM +0200, Andreas Kemnade wrote: > > > > Why is this a good fix and not defining the supported voltages? These > > > look like fairly standard linear range regulators. > > > I am fixing the definition of the two regulators in the patch. > > I am defining them as continuous. > > Voltage ranges are defined in > > arch/arm/boot/dts/twl4030.dtsi > > Only the continuous flag is missing. > > > Is there anything else do you want to be defined? > > These regulators are not continuous regulators as far as I can see, they > are normal linear range regulators and so should have their voltages > enumerable like any other linear range regulator. another thing which might be misleading: The patch belongs to the section after #define TWL4030_ADJUSTABLE_SMPS(label, offset, num, turnon_delay, remap_conf) that might be easily misread (because of too less context in the diff), or if line numbers change. It is *not* for #define TWL4030_ADJUSTABLE_LDO(label, offset, num, turnon_delay, remap_conf) Regards, Andreas
