On Mon, Jun 10, 2019 at 7:11 PM Grygorii Strashko <grygorii.strashko@xxxxxx> wrote: > This series contains set of patches from Russell King which were circulated > internally for quite some time already and I fill it's reasonable to move > future discussion upstream (and also avoid rebasing). > Fisrt two patches are fixes and the rest are big, great clean up > from Russell King. > > Personally, I like this clean up and refactoring very much and don't want > it to be lost. I share your view, it is very nice to have Russell's attention to detail shaping up this driver. I vaguely remember at some point wondering why we were not using gpio-mmio.c at least partially for this driver, as it share this characteristic of keeping a shadow copy of the registers around and seem to have offsets from 0..n in the registers, but I guess there is some specific good reason for not using the library? Yours, Linus Walleij
