Hi, * Tero Kristo <t-kristo@xxxxxx> [190404 08:12]: > From: Eric Ruei <e-ruei1@xxxxxx> > > The GFX modules on AM33xx SoCs have a hardreset line and are controlled > by a GFX reset line. Any clkctrl enable/disable operations cannot be > checked for module enabled/disabled status independent of the reset > operation, and this causes some unwanted timeouts in the kernel and > unbalanced states for the GFX clocks. These details should be handled > by the driver integration code itself. These last two patches should no longer be needed with ti-sysc. Well, at least based on testing with the earlier reset-simple driver patch and a test for sgx register access on am335x. On init we deassert rstctrl if configured and in reset, then enable clocks, and read the module revision. And the module is ready for child device driver(s) to probe, and do what they want with the rstctrl via a reset driver. If no child device driver(s) are configured, ti-sysc will just put the module rstctrl back to reset using reset driver. Regards, Tony