Hi,
* Keerthy <j-keerthy@xxxxxx> [190322 17:16]:
> +static int am43xx_check_off_mode_enable(void)
> +{
> + /*
> + * Check for am437x-sk-evm which due to HW design cannot support
> + * this mode reliably.
> + */
> + if (of_machine_is_compatible("ti,am437x-sk-evm") && enable_off_mode) {
> + pr_warn("WARNING: This platform does not support off-mode, entering DeepSleep suspend.\n");
> + return 0;
> + }
> +
> + return enable_off_mode;
> +}
Considering off-mode suspend depends on how the board is
wired for various things such as memory, PMIC and the related
signal lines, I agree using the machine compatible is the best
check we can do here.
But since the device can hang during suspend unless things are
configured right for the board, I suggest you rather list allowed
boards here that are known to work with off-mode.
Otherwise many out-of-tree boards might hang during suspend
mysteriously.
Regards,
Tony
