On Fri, 22 Mar 2019, Tony Lindgren wrote: > * Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> [190322 18:37]: > > How about putting these runtime PM additions into > > usb_hcd_platform_shutdown instead, so they will apply to all platform > > controller drivers? > > OK let's do that then. > > > Also, are you certain you want the pm_runtime_put_sync at the end? If > > the system is shutting down anyway, why waste time doing an extra > > runtime suspend? > > Well mostly to keep the calls paired. But maybe there are > also kexec reboot cases where we'd want to have things > properly disabled for PM before kexec. I'm not sure that makes sense. You can't actually disable anything for runtime PM from within a driver; all you can do is tell the runtime PM core that _you're_ not using the device any more. But if some other part of the system is still using it, it will remain at full power. Alan Stern
