Quoting Tero Kristo (2019-02-24 23:18:57) > On 22/02/2019 21:50, Stephen Boyd wrote: > > Quoting Tero Kristo (2019-01-15 01:15:11) > >> Hi Stephen, > >> > >> As requested, this series gets rid of CLK_IS_BASIC flag usage from > >> TI clock drivers. > >> > >> Boot tested on am3/am4/am5/omap3/omap4 series of SoCs. Also, ran a quick > >> suspend/resume test on omap3/omap4/am5. > >> > > > > I'm looking at clk-next now that this is all merged in and I still see > > one usage of CLK_IS_BASIC in the omap2 hwmod code. > > > > arch/arm/mach-omap2/omap_hwmod.c: if (__clk_get_flags(oh->_clk) & CLK_IS_BASIC) > > > > Can that also be removed? If not, what clk types are on this platform? > > Maybe I can remove CLK_IS_BASIC from every clk type except for the ones > > that this code is checking for. > > > > Hmm, I missed this in my update, only looked at the drivers/clk/ti > portion of code. However, this can be fixed with the following patch, I > would need to export the omap2_clk_is_hw_omap() func from the driver and > call it from the omap2 platform code. What do you think? Shall I post > this as an official change? This one still has the issue that I am > calling __clk_get_hw() though. Looks ok to me. Please post it as an official change. I think we should look into making clk domains with genpds and plumb that through the clk framework so that devices calling clk_get() can have their domains attached automatically on clk_get(). Maybe that would help here. Not sure.
