* Andreas Kemnade <andreas@xxxxxxxxxxxx> [190221 16:43]: > Hi, > > On Wed, 20 Feb 2019 14:31:32 -0800 > Tony Lindgren <tony@xxxxxxxxxxx> wrote: > > > * Andreas Kemnade <andreas@xxxxxxxxxxxx> [180922 09:48]: > > > When runtime is not enabled, pm_runtime_get_sync() returns -EACCESS, > > > the counter will be incremented but the resume callback not called, > > > so enumeration and charging will not start properly. > > > To avoid that happen, disable irq on suspend and recheck on resume. > > > > > > Practically this happens when the device is woken up from suspend by > > > plugging in usb. > > > > > > Signed-off-by: Andreas Kemnade <andreas@xxxxxxxxxxxx> > > > --- > > > Changes in v2: > > > * use pm suspend/resume callback instead of delayed_work > > > as suggested by Dmitry > > > > Hmm it just occurred to me that this issue too might be fixed with commit > > c6e2bd956936 ("i2c: omap: Use noirq system sleep pm ops to idle device > > for suspend"). Andreas, care to check? That is if this is still an > > issue. > > > this one made already its way into 4.20. But for the records, I will > build the latest 5.0-rc and revert it and will check if the problem > still occurs. OK thanks. > I do not think the patch you mentioned has something to do with this > because here solely the problem is about things happen on resume. OK > But on gta04 we had several irregular behavior regarding to actions > on the other i2c bus where all the sensors and touchscreen are located. > It happens rarely and most often when I am not up to debugging it. > So maybe your patch helps there. Yeah maybe, it's worth checking :) Regards, Tony