* Lee Jones <lee.jones@xxxxxxxxxx> [190214 09:21]: > On Mon, 11 Feb 2019, Tony Lindgren wrote: > > + ret = regcache_sync(twl6040->regmap); > > + if (ret) { > > + dev_err(twl6040->dev, "%s register write failed: %i\n", > > + __func__, ret); > > Please drop the __func__ and just use the standard format. > > Wouldn't something a little more forthcoming be better? > > "Failed to sync with the HW" ? Sure I'll send an updated patch. Regards, Tony