Hi,
On Tue, Feb 05, 2019 at 01:52:04PM +0100, Linus Walleij wrote:
> This augments the CBUS GPIO I2C driver to use GPIO
> descriptors for clock, sel and data. We drop the platform
> data that was only used for carrying GPIO numbers and
> use machine descriptor tables instead.
>
> Cc: linux-omap@xxxxxxxxxxxxxxx
> Cc: Tony Lindgren <tony@xxxxxxxxxxx>
> Cc: Aaro Koskinen <aaro.koskinen@xxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> ---
> This is only compile tested, I hope someone can test it
> on the n770, it seems like Aaro is still using it!
Unfortunately it doesn't work, so the device shuts down...
> +static struct gpiod_lookup_table nokia770_cbus_gpio_table = {
> + .table = {
> + GPIO_LOOKUP("mpuio", 9, "clk", 0),
> + GPIO_LOOKUP("mpuio", 10, "dat", 0),
> + GPIO_LOOKUP("mpuio", 11, "sel", 0),
> + { },
> + },
> };
Should there be dev_id? I tried adding "i2c-cbus-gpio.2" but it still
didn't work...
Minor note:
> + gpiod_set_consumer_name(chost->dat, "CBUS data");
Maybe use "CBUS dat" to be consistent with other pins.
A.
