Re: [PATCH 3/3] Adds device tree file for McGill's IceBoard, based on TI AM3874.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

* Tony Lindgren <tony@xxxxxxxxxxx> [190107 15:05]:
> * Graeme Smecher <gsmecher@xxxxxxxxxxxxxxxxxxx> [190103 23:16]:
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/am3874-iceboard.dts
> > +/ {
> > +	model = "Winterland IceBoard";
> > +	compatible = "winterland,iceboard", "ti,dm8148", "ti,dm814";
> > +
> > +	memory@80000000 {
> > +		device_type = "memory";
> > +		reg = <0x80000000 0x40000000>;	/* 1 GB */
> > +	};
> 
> 
> You probably also want chosen with stdout-path here too so
> you can see early debug messages with CONFIG_SERIAL_EARLYCON=y
> and earlycon in the kernel command line. See for example what
> am335x-bone-common.dtsi.

Naturally the stdout-path you can add naturally later too.

I noticed few minor issues though while about to apply
this dts patch. Care to run it through checkpatch with
scripts/checpatch.pl --strict?

Not much we can do about the over 80 line warnings with
dts files.. But please do take a look at the other warnings
and switch to use SPDX-License-Identifier.

And just drop the #if 0 and commented out debug or pending
code for now. Let's add that stuff when working in
additional patches.

Cheers,

Tony



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux