Hi Rob, On 22/01/19 6:18 AM, Rob Herring wrote: > On Mon, Jan 14, 2019 at 06:54:09PM +0530, Kishon Vijay Abraham I wrote: >> Document "atu" reg-names required to get the register space for ATU in >> Synopsys designware core version >= 4.80. >> >> Signed-off-by: Kishon Vijay Abraham I <kishon@xxxxxx> >> --- >> Documentation/devicetree/bindings/pci/designware-pcie.txt | 7 +++++-- >> 1 file changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/pci/designware-pcie.txt b/Documentation/devicetree/bindings/pci/designware-pcie.txt >> index c124f9bc11f3..5561a1c060d0 100644 >> --- a/Documentation/devicetree/bindings/pci/designware-pcie.txt >> +++ b/Documentation/devicetree/bindings/pci/designware-pcie.txt >> @@ -4,8 +4,11 @@ Required properties: >> - compatible: >> "snps,dw-pcie" for RC mode; >> "snps,dw-pcie-ep" for EP mode; >> -- reg: Should contain the configuration address space. >> -- reg-names: Must be "config" for the PCIe configuration space. >> +- reg: For designware cores version < 4.80 contains the configuration >> + address space. For designware core version >= 4.80, contains >> + the configuration and ATU address space >> +- reg-names: Must be "config" for the PCIe configuration space and "atu" for >> + the ATU address space. > > I'm pretty sure we already have other platforms with an ATU. Those all > just represent it with the other ctrl registers? So maybe this is TI > specific that it is separate. Or should have some conditional like 'if > the ATU space is separate, the reg-name should be atu'. This is specific to Synopsys Designware version >= 4.80 and not to TI. The first platform used a fixed offset to get the atu_base which is incorrect. In the "reg" binding I've noted this dependency. Thanks Kishon
