* Adam Ford <aford173@xxxxxxxxx> [190118 20:22]: > On Thu, Dec 27, 2018 at 12:55 PM Adam Ford <aford173@xxxxxxxxx> wrote: > > > > On Thu, Dec 27, 2018 at 12:53 PM Tony Lindgren <tony@xxxxxxxxxxx> wrote: > > > > > > * Adam Ford <aford173@xxxxxxxxx> [181227 15:53]: > > > > On Sun, Dec 23, 2018 at 10:17 AM Tony Lindgren <tony@xxxxxxxxxxx> wrote: > > > > > > > > > > * Adam Ford <aford173@xxxxxxxxx> [181222 20:17]: > > > > > > This fixes an issue where the MMC errors our during boot which > > > > > > requires the user to eject and re-insert the MMC. > > > > > > > > > > > > The bootloader has been updated for a while to correct set the > > > > > > pbias for the GPIO pins. Kernels 4.20-RC1+ are getting hung up > > > > > > on intializing the MMC. Removing the duplicative PBIAS setting > > > > > > appears to eliminate the issue. > > > > > > > > > > Hmm I wonder if the root cause might be some PBIAS regulator > > > > > regression between v4.19 and v4.20-rc series? > > > > > > > > Possibly, but I haven't bisected it, but do you think this is even > > > > necessary if the bootloader correctly addresses this now? If > > > > anything, pdata quirks seems to me to be the wrong place, and we > > > > should add the IO disable/enable features into the pbias driver. I'd > > > > like to get this applied for 4.20.1 if possible, but I understand if > > > > you want more investigation. I am just not sure when I can get to it. > > > > As of right now, 4.20 doesn't properly boot the Torpedo board without > > > > ejecting and reinserting the card. > > > > > > Yeah so there seems to be a MMC card detect GPIO regression > > > caused by commit e63201f19438 ("mmc: omap_hsmmc: Delete platform > > > data GPIO CD and WP") that I just sent an email about. > > > > > > Anyways, yeah if we can do the IO disable/enable into the pbias > > > driver and get rid of more pdata-quirks.c handling that would > > > be great. > > > > I'll try to work on that this weekend. > > > > > > Care to check after reverting e63201f19438 and removing the > > > pdata-quirks.c pieces if more changes are still needed? > > I cannot build master and just revert e63201f19438, I get build > errors. I can go back to version e7fed63b59310 which is the commit > just before e63201f19438 and apply my patch and it still boots. > > I can apply my patch against master without reverting, and it still > boots, so I think it's safe to apply this patch. OK thanks will apply this week once I'm done with fixes for the -rc cycle. Regards, Tony