Hi, On Mon, 21 Jan 2019 09:07:43 -0800 Tony Lindgren <tony@xxxxxxxxxxx> wrote: > * Tero Kristo <t-kristo@xxxxxx> [190121 07:13]: > > On 18/01/2019 21:45, Tony Lindgren wrote: > > > * Andreas Kemnade <andreas@xxxxxxxxxxxx> [190118 19:39]: > > > > Hi, > > > > > > > > On Fri, 18 Jan 2019 10:36:30 -0800 > > > > Tony Lindgren <tony@xxxxxxxxxxx> wrote: > > > > > > > > [...] > > > > > til the next workaround. > > > > > > > > > > > That flags also causes the iclk being enabled/disabled > > > > > > manually. > > > > > > > > > > Yes but SWSUP_IDLE for the interface clock to me currently > > > > > just means: > > > > > > > > > > "manually enable and disable ocp interface clock" > > > > > > > > > well, if we want to manually disable it and not automatically, > > > > we have to disable autoidle or it will be automatically disabled. > > > > > > > > Disabling it manually when it is already auto-disabled (by autoidle) is > > > > just practically a no-op towards the clock. > > > > > > OK I buy that :) It should be probably added to the patch > > > description to make it clear what it changes. > > > > > > Tero, any comments on this change? > > > > Well, seeing the flag is pretty much only used for a handful of hwmods > > nowadays, it should be fine. OMAP3 PM should be tested with this change > > though, as there are couple of hwmods impacted on that platform. I wonder > > what happens to cpuidle when display is active... > > OK so that's a good test case. AFAIK, we should have DSS idle > and have the SoC hit at least core retention with DSI command mode > displays. I don't know if this patch would block DSS autoidle then > or not.. I'm guessing 80% chance that we still need DSS hit runtime > suspend to enter SoC idle states meaning this patch would not > affect it :) > So this is a call to Nokia N950 owners? Unfortunately, I do not have one. I have seen on non-command-mode displays that dss goes to idle when display is blanked. Regards, Andreas
Attachment:
pgpmjjSMVZlhF.pgp
Description: OpenPGP digital signature
