On Tue, Jan 15, 2019 at 10:01:49AM +0300, Dan Carpenter wrote:
> The ti_clk_parse_divider_data() function is only called from
> _get_div_table_from_setup(). That function doesn't look at the return
> value but instead looks at the "*table" pointer. In this case, if the
> kcalloc() fails then *table is NULL (which means success). It should
> instead be an error pointer.
>
> The ti_clk_parse_divider_data() function has two callers. One checks
> for errors and the other doesn't. I have fixed it so now both handle
> errors.
>
> Fixes: 4f6be5655dc9 ("clk: ti: divider: add driver internal API for parsing divider data")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> drivers/clk/ti/divider.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/ti/divider.c b/drivers/clk/ti/divider.c
> index 8d77090ad94a..4c48ef424ad5 100644
> --- a/drivers/clk/ti/divider.c
> +++ b/drivers/clk/ti/divider.c
> @@ -403,8 +403,10 @@ int ti_clk_parse_divider_data(int *div_table, int num_dividers, int max_div,
> num_dividers = i;
>
> tmp = kcalloc(valid_div + 1, sizeof(*tmp), GFP_KERNEL);
> - if (!tmp)
> + if (!tmp) {
> + *table = PTR_ERR(-ENOMEM);
Oh wow... I don't know how I screwed that up. :(
Let me resend.
regards,
dan carpenter
