On Mon, 7 Jan 2019 at 17:12, Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote: > > Tony Lindgren <tony@xxxxxxxxxxx> writes: > > > * Ulf Hansson <ulf.hansson@xxxxxxxxxx> [190102 12:02]: > >> > >> However, if this is about an out-of-band IRQ line, instead of using > >> the SDIO IRQs on DAT1, I think management of that, belongs in the wlan > >> (or gpiochip) layers. > > > > Yes this can be handled at the gpiochip layer. > > > >> We have to distinguish if "down" has a strict requirement to power off > >> the wlan-chip. > >> > >> For example, in "flight mode", is it okay to leave the wlan chip > >> powered on and thus potentially also having its radio part active? > > > > I don't know. If unsure, we should at least have that possibility > > available for future versions if needed. It might also help a bit > > with PM measurements :) > > I don't know if there are any written rules but I have preferred that in > wireless drivers "ifconfig down" means that all power is turned off on > the device, at least this way user space can achive maximum power > savings. And there's also a simple way to start the firmware from clean > state, we all know how buggy firmwares are so I think that's important > as well. Alright, I buy this! I am going to have a look to see how we can accomplish this in the best way, but I need some more time before I can post something. In the meantime, let's go with Tony's suggestion to fix the regression. I am about to post a patch. Kind regards Uffe
